Skip to content

release: 0.2.1: PyPI and crates.io metadata, pyarrow required, 429 retry, cron removed, RELEASING.md - #751

Open
techgopal wants to merge 30 commits into
mainfrom
ci/s2-release-021
Open

techgopal wants to merge 30 commits into
mainfrom
ci/s2-release-021

Conversation

@techgopal

@techgopal techgopal commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Packaging area, one PR for the 0.2.1 acceptance fixes in sonnet-2's lane. Issue ids (research/qa/2026-11-14-acceptance-issues.md):

  • PY-021, PY-032, PY-031: the wheels are built with the cloud feature (s3, gs, az, https, hf); Data sources guide; python/tests/test_cloud_stores.py covers all five schemes.
  • SQL-1, PY-022: pyarrow>=16 is a required dependency; the wheel test installs the wheel with --no-deps so musllinux (no pyarrow wheel) does not build pyarrow from source.
  • PY-006, RS-3: PyPI and crates.io metadata, PYPI.md, crate READMEs.
  • RS-15: telemetry-otlp feature on krishiv and krishiv-cli.
  • Also: 429 retry in publish-crates.yml, nightly cron removed, RELEASING.md, version 0.2.1, CHANGELOG.

Not in this PR: RS-1 (CLI install line, docs-3), PY-027/RS-22 (commit in build info, 0.2.2), RS-17 (empty features, owner).

Opus review: ops/reviews/2026-11-13-sonnet-2-release-021-diff.md. Open question B1 (pyarrow on musllinux) is answered by the wheel-test change; a musllinux user without a pyarrow wheel gets a source build on pip install krishiv.

…, 429 retry for the crate upload step

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
…ords, classifiers, project URLs

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
…p, changelog)

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
…hiv server, Spark Connect)

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
…thub-only commit, unsourced speedup claim removed

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>

# Conflicts:
#	crates/krishiv-connectors-delta/Cargo.toml
#	crates/krishiv-session/Cargo.toml
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-15T09:25:34.148261Z
We couldn’t complete this review. Comment @codex review to try again.
bf65c89 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@techgopal

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 1677f774ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
@codspeed

codspeed Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 32 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 224 untouched benchmarks
⏩ 5 skipped benchmarks1


Comparing ci/s2-release-021 (bf65c89) with main (6f40584)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@techgopal

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c501a6266

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread python/pyproject.toml Resolved
… is from PyPI

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
@techgopal

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: ab04ba9a15

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…sion registration, deploy, check)

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
@techgopal

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 373ccfd143

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
…, gs://, az://); wheel test against MinIO; Data sources guide

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
@techgopal

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 43789d8c12

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
…out a pyarrow wheel (musllinux) does not build pyarrow from source

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
@techgopal

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c92d5fb04f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/scripts/wheel-test.sh Resolved
…s for the Krishiv wheel only

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
@techgopal

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: b82d7f69bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…(RS-15)

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
…-031, PY-032)

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
…, PY-032, SQL-1, PY-022, PY-006, RS-3, RS-15)

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>

# Conflicts:
#	crates/krishiv-cli/Cargo.toml
Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
@techgopal

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 441d7e85c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ep pinned to 0.2.1; https is Spark's UNSUPPORTED_FILE_SYSTEM, not a wheel test case

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
@techgopal

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: b881e7218c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
…ered cfg branch)

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
@techgopal

Copy link
Copy Markdown
Contributor Author

wheel-sizes: what grew, and what could be cut

  • Cause: one change, 43789d8, makes cloud a default feature of the Python wheel (krishiv-session/cloud -> object_store/aws, azure, gcp, http + http), so s3://, gs://, az:// work. 0.2.0 shipped without it and those URLs failed with KRISHIV_UNSUPPORTED_FEATURE. Nothing else in the PR touches the binary (the rest is metadata, READMEs, version pins).
  • Size (CI table, bytes): manylinux x86_64 abi3 21.82 MB -> 25.29 MB (+15.9%), musllinux x86_64 22.05 -> 25.52 (+15.8%), manylinux aarch64 19.02 -> 21.63 (+13.7%), macOS arm64 18.92 -> 21.55 (+13.9%). cp314t is within 0.1% of abi3. That is about +2.6 to +3.5 MB per wheel for three cloud SDK clients (request signing, XML/JSON, TLS client).
  • Already cut: the wheel is built with the dist profile (fat LTO, codegen-units = 1, strip = symbols, mimalloc). Nothing cheap is left there. opt-level = "s" would shrink the whole wheel but costs speed (the profile exists because fat LTO bought 1.7% on TPC-H), so I did not try it.
  • Real options: (a) accept as is and label budget-approved (recommended: it fixes a 0.2.0 P0 and the growth is the three clouds); (b) ship a second krishiv-cloud wheel/extra, which is more packaging and a worse first run; (c) drop gcp or azure from the default, about 0.7 to 1 MB each (my estimate, not measured), at the cost of two of the three schemes. Owner's call.

@techgopal

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@techgopal

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

…a retry date; the offline cloud-store test runs without pyarrow (review of #751)

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
@techgopal

Copy link
Copy Markdown
Contributor Author

Review of 4b209a0 (Opus, ops/reviews/2026-11-15-sonnet-2-pr751-diff.md): no blockers. Fixed in 1685294: the crate-upload retry fell back to 60 s instead of 600 s when the 429 message had no date; the offline cloud-store test no longer skips the whole module without pyarrow (so musllinux runs it).

For the owner (not changed): (1) pyarrow is now a required dependency and has no musllinux wheels, so pip install krishiv on musl builds pyarrow from source or fails; 0.2.0 installed there. Confirm that is intended, and add the musl workaround to PYPI.md. (2) the offline test's gs/az/hf cases are not pointed at a closed port, so they can be slow on a runner. (3) the wheel test uses --no-deps, so no leg checks that the pyarrow requirement installs.

@techgopal techgopal added the budget-approved Maintainer approval for exceeding the binary/dependency budget label Nov 15, 2026
Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
@techgopal

Copy link
Copy Markdown
Contributor Author

Merged main (#776 frees runner disk; the last test failure was No space left on device). zizmor failure is the dtolnay pin on main, fixed by #775. @codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

budget-approved Maintainer approval for exceeding the binary/dependency budget

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant